Fix/template issues new #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushaga14
reviewed
Nov 21, 2023
| @@ -44,3 +44,6 @@ validate: | |||
| response_code: | |||
| gte: 200 | |||
| lt: 300 | |||
| response_payload: | |||
There was a problem hiding this comment.
isn't 200 resp code enough for noauth test?
There was a problem hiding this comment.
No harm adding response length check @ayushaga14
There was a problem hiding this comment.
discussed with ankush, we should also consider the case where initial response length was 0
ayushaga14
reviewed
Nov 21, 2023
Comment on lines
+59
to
+68
| - "Django tried these url patterns" | ||
| - "Django version" | ||
| - "Exception Type" | ||
| - "Template rendering" | ||
| - "Request Method" | ||
| - "Request URL" | ||
| - "Django Settings" | ||
| - "Python Executable" | ||
| - "Python Path" | ||
| - "Server time" |
There was a problem hiding this comment.
- "Request Method"
- "Request URL"
- "Exception Type"
Just confirm once if these can give false positives
ayushaga14
reviewed
Nov 21, 2023
Comment on lines
+34
to
+35
| not_contains_either: | ||
| - root |
There was a problem hiding this comment.
we dont want the original request / response to have possibilities of LFI, without even modifying the request
| @@ -52,3 +52,5 @@ validate: | |||
| response_payload: | |||
| contains_either: | |||
| - "hello world" | |||
| not_contains_either: | |||
| - "| echo 'hello world'" | |||
There was a problem hiding this comment.
Why not just check for "echo 'hello world'"?
There was a problem hiding this comment.
you have a point, but we dont want our own modified request to reflect in the response payload, we can use either to validate that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.