Skip to content

Commit

Permalink
fix: tolerate entra id pkce spec deviation
Browse files Browse the repository at this point in the history
Signed-off-by: Kent Rancourt <[email protected]>
  • Loading branch information
krancour committed Jan 24, 2025
1 parent 5b27901 commit 0ac6d16
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ui/src/features/auth/oidc-login.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ export const OIDCLogin = ({ oidcConfig }: Props) => {
})
.then((response) => processDiscoveryResponse(issuerUrl, response))
.then((response) => {
if (response.code_challenge_methods_supported?.includes('S256') !== true) {
if (response.code_challenge_methods_supported?.includes('S256') !== true &&

Check failure on line 68 in ui/src/features/auth/oidc-login.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck-ui

Replace `response.code_challenge_methods_supported?.includes('S256')·!==·true·&&·` with `⏎············response.code_challenge_methods_supported?.includes('S256')·!==·true·&&`
!issuerUrl.toString().startsWith('https://login.microsoftonline.com')) {

Check failure on line 69 in ui/src/features/auth/oidc-login.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck-ui

Replace `··!issuerUrl.toString().startsWith('https://login.microsoftonline.com')` with `!issuerUrl.toString().startsWith('https://login.microsoftonline.com')⏎··········`
throw new Error('OIDC config fetch error');
}

Expand Down

0 comments on commit 0ac6d16

Please sign in to comment.