chore: fix linter issues

Signed-off-by: Hidde Beydals <[email protected]>
akuity · Dec 2, 2024 · 4ea7964 · 4ea7964
1 parent 0682cf1
commit 4ea7964
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 12 deletions.
diff --git a/internal/api/promote_downstream_v1alpha1.go b/internal/api/promote_downstream_v1alpha1.go
@@ -120,7 +120,7 @@ func (s *server) PromoteDownstream(
 	}
 
 	for _, downstream := range downstreams {
-		if err := s.authorizeFn(
+		if err = s.authorizeFn(
 			ctx,
 			"promote",
 			kargoapi.GroupVersion.WithResource("stages"),
@@ -158,7 +158,9 @@ func (s *server) PromoteDownstream(
 					Namespace: downstream.Namespace,
 					Name:      downstream.Spec.PromotionTemplateRef.Name,
 				}, template); err != nil {
-					promoteErrs = append(promoteErrs, fmt.Errorf("get PromotionTemplate %q: %w", downstream.Spec.PromotionTemplateRef.Name, err))
+					promoteErrs = append(promoteErrs, fmt.Errorf(
+						"get PromotionTemplate %q: %w", downstream.Spec.PromotionTemplateRef.Name, err,
+					))
 					continue
 				}
 

diff --git a/internal/api/promote_to_stage_v1alpha1.go b/internal/api/promote_to_stage_v1alpha1.go
@@ -98,7 +98,7 @@ func (s *server) PromoteToStage(
 		)
 	}
 
-	if err := s.authorizeFn(
+	if err = s.authorizeFn(
 		ctx,
 		"promote",
 		schema.GroupVersionResource{

diff --git a/internal/controller/stages/regular_stages_test.go b/internal/controller/stages/regular_stages_test.go
@@ -245,7 +245,7 @@ func TestRegularStageReconciler_Reconcile(t *testing.T) {
 					string,
 					client.Object,
 					client.Patch,
-				...client.SubResourcePatchOption,
+					...client.SubResourcePatchOption,
 				) error {
 					return fmt.Errorf("status update error")
 				},
@@ -287,7 +287,7 @@ func TestRegularStageReconciler_Reconcile(t *testing.T) {
 					string,
 					client.Object,
 					client.Patch,
-				...client.SubResourcePatchOption,
+					...client.SubResourcePatchOption,
 				) error {
 					return fmt.Errorf("status update error")
 				},
@@ -3653,7 +3653,7 @@ func TestRegularStageReconciler_abortVerification(t *testing.T) {
 					client.WithWatch,
 					client.Object,
 					client.Patch,
-				...client.PatchOption,
+					...client.PatchOption,
 				) error {
 					return fmt.Errorf("something went wrong")
 				},
@@ -3905,7 +3905,7 @@ func TestRegularStageReconciler_findExistingAnalysisRun(t *testing.T) {
 					context.Context,
 					client.WithWatch,
 					client.ObjectList,
-				...client.ListOption,
+					...client.ListOption,
 				) error {
 					return fmt.Errorf("list error")
 				},
@@ -5072,7 +5072,7 @@ func TestRegularStageReconciler_autoPromotionAllowed(t *testing.T) {
 					client.WithWatch,
 					client.ObjectKey,
 					client.Object,
-				...client.GetOption,
+					...client.GetOption,
 				) error {
 					return fmt.Errorf("something went wrong")
 				},

diff --git a/internal/kargo/kargo_test.go b/internal/kargo/kargo_test.go
@@ -44,7 +44,7 @@ func TestNewPromotion(t *testing.T) {
 					Steps: []kargoapi.PromotionStep{
 						{
 							Uses: "test-step",
-							As: "test-step",
+							As:   "test-step",
 						},
 					},
 				},
@@ -59,10 +59,10 @@ func TestNewPromotion(t *testing.T) {
 			},
 		},
 		{
-			name: "Promote stage with very long name",
+			name:      "Promote stage with very long name",
 			namespace: "kargo-demo",
-			stage: veryLongResourceName,
-			freight: testFreight,
+			stage:     veryLongResourceName,
+			freight:   testFreight,
 			assertions: func(t *testing.T, promo kargoapi.Promotion) {
 				require.Len(t, promo.Name, 253)
 				parts := strings.Split(promo.Name, ".")