fix(ui): tolerate entra id RFC8414 deviation (#3359)

Signed-off-by: Kent Rancourt <[email protected]>
akuity · Jan 24, 2025 · b4458c5 · b4458c5
1 parent ec10aca
commit b4458c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/ui/src/features/auth/oidc-login.tsx b/ui/src/features/auth/oidc-login.tsx
@@ -65,7 +65,10 @@ export const OIDCLogin = ({ oidcConfig }: Props) => {
       })
         .then((response) => processDiscoveryResponse(issuerUrl, response))
         .then((response) => {
-          if (response.code_challenge_methods_supported?.includes('S256') !== true) {
+          if (
+            response.code_challenge_methods_supported?.includes('S256') !== true &&
+            !issuerUrl.toString().startsWith('https://login.microsoftonline.com')
+          ) {
             throw new Error('OIDC config fetch error');
           }
 

diff --git a/ui/src/features/auth/token-renew.tsx b/ui/src/features/auth/token-renew.tsx
@@ -56,7 +56,10 @@ export const TokenRenew = () => {
       })
         .then((response) => processDiscoveryResponse(issuerUrl, response))
         .then((response) => {
-          if (response.code_challenge_methods_supported?.includes('S256') !== true) {
+          if (
+            response.code_challenge_methods_supported?.includes('S256') !== true &&
+            !issuerUrl.toString().startsWith('https://login.microsoftonline.com')
+          ) {
             throw new Error('OIDC config fetch error');
           }