Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add sample Dex Azure connector. #2352

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

BasJ93
Copy link
Contributor

@BasJ93 BasJ93 commented Jul 26, 2024

As discussed in #2338 I added the Azure connector sample for Dex to the values.yaml file.

@BasJ93 BasJ93 requested a review from a team as a code owner July 26, 2024 13:33
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 7192199
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66a3b692d198360008aeb73f
😎 Deploy Preview https://deploy-preview-2352.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BasJ93 BasJ93 changed the title Add sample Dex Azure connector. docs: Add sample Dex Azure connector. Jul 26, 2024
charts/kargo/values.yaml Outdated Show resolved Hide resolved
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one tiny change, but this is great @BasJ93. Thank you so much!

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.64%. Comparing base (6dc367b) to head (7192199).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2352   +/-   ##
=======================================
  Coverage   47.64%   47.64%           
=======================================
  Files         244      244           
  Lines       17392    17392           
=======================================
  Hits         8287     8287           
  Misses       8694     8694           
  Partials      411      411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Jul 26, 2024
Merged via the queue into akuity:main with commit aff97d8 Jul 26, 2024
24 of 25 checks passed
@BasJ93 BasJ93 deleted the add-azure-oidc-dex-example branch July 26, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants