Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conditional step execution #3485

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Feb 11, 2025

Fixes: #3125

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 63afbf1
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67b7a2aa3b2710000869bbbd
😎 Deploy Preview https://deploy-preview-3485.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.47%. Comparing base (fe65204) to head (63afbf1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/simple_engine_promote.go 62.50% 7 Missing and 2 partials ⚠️
internal/directives/promotions.go 69.56% 5 Missing and 2 partials ⚠️
internal/controller/promotions/promotions.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3485      +/-   ##
==========================================
+ Coverage   52.27%   52.47%   +0.20%     
==========================================
  Files         290      294       +4     
  Lines       26330    26696     +366     
==========================================
+ Hits        13764    14009     +245     
- Misses      11814    11917     +103     
- Partials      752      770      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco force-pushed the promo-step-if-condition branch 2 times, most recently from 00ac6e1 to 3a7e773 Compare February 11, 2025 06:19
@hiddeco hiddeco force-pushed the promo-step-if-condition branch from 3a7e773 to d6f6872 Compare February 20, 2025 21:35
@hiddeco hiddeco force-pushed the promo-step-if-condition branch from d6f6872 to 63afbf1 Compare February 20, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional step execution
1 participant