-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Long Stage names result in AnalysisRun creation failures during promotion #3520
base: main
Are you sure you want to change the base?
fix: Long Stage names result in AnalysisRun creation failures during promotion #3520
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…itting max length issues due to long stage names Signed-off-by: Aidan Rowe <[email protected]>
e994877
to
a1b4010
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3520 +/- ##
==========================================
+ Coverage 52.27% 52.43% +0.15%
==========================================
Files 290 294 +4
Lines 26330 26663 +333
==========================================
+ Hits 13764 13980 +216
- Misses 11814 11915 +101
- Partials 752 768 +16 ☔ View full report in Codecov by Sentry. |
Tentatively assigned to v1.3.0, but might be a good candidate to be deferred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think docs/docs/50-user-guide/20-how-to-guides/60-verification.md
contains a label example that has to be updated.
Signed-off-by: Aidan Rowe <[email protected]>
Thanks @hiddeco, fixed! |
Closes #3202
Long Stage names cause errors during promotions due to calculated labels (
kargo.akuity.io/promotion
) on AnalysisRun resources exceeding the max 63 character limit of a label value.This solution moves the
kargo.akuity.io/promotion
label to an annotation which has a much larger max length. It doesn't appear this label key is used for selecting at the moment so its largely an informative value.An alternative approach to truncate Stage name was considered (with hashing for uniqueness) but that greatly reduces legibility within the UI (IMO). Doing it inconsistently might work, but then impacts ability to debug and map relationships with resources easily.
This solution strikes a middle ground to unblock longer Stage names and give time for a more considered approach to naming/labeling conventions if its required.