Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api server): add support for streaming logs from completed analysisruns #3678

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

krancour
Copy link
Member

@krancour krancour commented Mar 19, 2025

WIP

Back end components of #3641

Still needs corresponding functionality added to CLI. Done

UI components to be added in a follow-up PR. (#3674)

cc @jessesuen @hiddeco @Marvin9 @gdsoumya

@krancour krancour added this to the v1.4.0 milestone Mar 19, 2025
@krancour krancour self-assigned this Mar 19, 2025
@krancour krancour requested a review from a team as a code owner March 19, 2025 22:45
@krancour krancour marked this pull request as draft March 19, 2025 22:45
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit e048904
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67dc8c3c00b8780008d2443c
😎 Deploy Preview https://deploy-preview-3678.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 43.84236% with 228 lines in your changes missing coverage. Please review.

Project coverage is 21.90%. Comparing base (1e623df) to head (e048904).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/server/get_analysisrun_logs_v1alpha1.go 60.33% 115 Missing and 2 partials ⚠️
internal/cli/cmd/logs/logs.go 0.00% 78 Missing ⚠️
...ice/v1alpha1/svcv1alpha1connect/service.connect.go 0.00% 18 Missing ⚠️
internal/server/config/config.go 0.00% 10 Missing ⚠️
internal/cli/option/flag.go 0.00% 4 Missing ⚠️
cmd/cli/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
+ Coverage   21.81%   21.90%   +0.08%     
==========================================
  Files         310      312       +2     
  Lines       64652    65199     +547     
==========================================
+ Hits        14105    14283     +178     
- Misses      49782    50149     +367     
- Partials      765      767       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
@krancour krancour force-pushed the krancour/verification-logs-endpoint branch from 1a34a9e to 7cd2fb6 Compare March 20, 2025 19:25
@krancour krancour marked this pull request as ready for review March 20, 2025 19:26
Signed-off-by: Kent Rancourt <[email protected]>

Co-authored-by: Hidde Beydals <[email protected]>
@krancour
Copy link
Member Author

Thanks for reviewing @hiddeco. Going to hold off on merge until I've heard from @Marvin9 and @gdsoumya as I want to be sure this meshes well with things they are each working on.

@Marvin9
Copy link
Contributor

Marvin9 commented Mar 21, 2025

I am testing this against UI

Copy link
Contributor

@Marvin9 Marvin9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp for UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants