This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
fix isReactComponent returning true for blank input #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isReactComponent
returnedtrue
for blank inputs (e.g.undefined
), which could produce confusing error messages. E.g. from Vue if you hadcomponents: {MyComponent: undefined}
(could be undefined because of e.g. a failing import) it would display a Vuera ReactWrapper error instead of the normal Vue "[Vue warn]: Unknown custom element" error.