add light mode for yeelink.bhf_light.v1/v2 #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-one
approved these changes
Aug 24, 2023
| "access": ["read", "write"], | ||
| "value-list": [ | ||
| {"value": 1, "description": "daylight"}, | ||
| {"value": 5, "description": "nightlight"} |
There was a problem hiding this comment.
建议这里的描述使用Day/Night，能够支持本地化翻译。
hass-xiaomi-miot/custom_components/xiaomi_miot/translations/zh-Hans.json
Lines 229 to 243 in 279ad0e
There was a problem hiding this comment.
好的，多谢修正。
我之前理解有误，以为这里只能填经由 miio_props 拿到的 light_mode 的值
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.