-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nvim themes from ghostty #139
Open
xdannyrobertsx
wants to merge
2
commits into
alacritty:master
Choose a base branch
from
xdannyrobertsx:nvim-themes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Color theme ported from Ghostty NvimDark theme | ||
|
||
[colors.primary] | ||
background = '#14161b' | ||
foreground = '#e0e2ea' | ||
|
||
[colors.cursor] | ||
text = '#14161b' | ||
cursor = '#9b9ea4' | ||
|
||
[colors.selection] | ||
background = '#4f5258' | ||
foreground = '#e0e2ea' | ||
|
||
[colors.normal] | ||
black = '#07080d' | ||
red = '#ffc0b9' | ||
green = '#b3f6c0' | ||
yellow = '#fce094' | ||
blue = '#a6dbff' | ||
magenta = '#ffcaff' | ||
cyan = '#8cf8f7' | ||
white = '#eef1f8' | ||
|
||
[colors.bright] | ||
black = '#4f5258' | ||
red = '#ffc0b9' | ||
green = '#b3f6c0' | ||
yellow = '#fce094' | ||
blue = '#a6dbff' | ||
magenta = '#ffcaff' | ||
cyan = '#8cf8f7' | ||
white = '#eef1f8' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Color theme ported from Ghostty NvimLight theme | ||
|
||
[colors.primary] | ||
background = '#e0e2ea' | ||
foreground = '#14161b' | ||
|
||
[colors.cursor] | ||
text = '#e0e2ea' | ||
cursor = '#9b9ea4' | ||
|
||
[colors.selection] | ||
background = '#9b9ea4' | ||
foreground = '#14161b' | ||
|
||
[colors.normal] | ||
black = '#07080d' | ||
red = '#590008' | ||
green = '#005523' | ||
yellow = '#6b5300' | ||
blue = '#004c73' | ||
magenta = '#470045' | ||
cyan = '#007373' | ||
white = '#eef1f8' | ||
|
||
[colors.bright] | ||
black = '#4f5258' | ||
red = '#590008' | ||
green = '#005523' | ||
yellow = '#6b5300' | ||
blue = '#004c73' | ||
magenta = '#470045' | ||
cyan = '#007373' | ||
white = '#eef1f8' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly does Ghostty contribute here? You said yourself these are just from iterm's website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iTerm contains these themes, but from what i've seen, Ghostty's been the one to popularize them. I didn't initially find that these themes came from iTerm, when I looked at them through Ghostty's theme selector, so if I were a new user and were searching for the theme, I might use the term Ghostty.
I'm more than happy to change the name of the PR and any references to Ghostty, just let me know please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point is to reference the original source, since it's where the theme is developed/etc, I'd really expect the neovim itself to be the source though, to some extent...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the theme name simply references Nvim, but doesn't actually come from it. The source of the colors seem to come from iTerm itself:
https://raw.githubusercontent.com/mbadolato/iTerm2-Color-Schemes/master/schemes/NvimLight.itermcolors