Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nvim themes from ghostty #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,8 @@ configuration file.
| **_nordfox_**<br>[source](https://github.com/EdenEast/nightfox.nvim/blob/7557f26defd093c4e9bc17f28b08403f706f5a44/extra/nordfox/alacritty.toml) | ![nordfox](images/nordfox.png) |
| **_nordic_**<br>[source](https://github.com/AlexvZyl/nordic.nvim) | ![nordic](images/nordic.png) |
| **_nord_light_**<br>[source](https://github.com/nordtheme/alacritty/issues/28#issuecomment-1422225211) | ![nord](images/nord_light.png) |
| **_nvim_dark_** | ![nvim_dark](images/nvim_dark.png) |
| **_nvim_light_** | ![nvim_light](images/nvim_light.png) |
| **_oceanic_next_**<br>[source](https://github.com/voronianski/oceanic-next-color-scheme) | ![oceanic_next](images/oceanic_next.png) |
| **_omni_**<br>[source](https://github.com/getomni/alacritty/blob/main/omni.yml) | ![omni](images/omni.png) |
| **_one_dark_** | ![one_dark](images/one_dark.png) |
Expand Down
Binary file added images/nvim_dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/nvim_light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
33 changes: 33 additions & 0 deletions themes/nvim_dark.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Color theme ported from Ghostty NvimDark theme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does Ghostty contribute here? You said yourself these are just from iterm's website?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iTerm contains these themes, but from what i've seen, Ghostty's been the one to popularize them. I didn't initially find that these themes came from iTerm, when I looked at them through Ghostty's theme selector, so if I were a new user and were searching for the theme, I might use the term Ghostty.

I'm more than happy to change the name of the PR and any references to Ghostty, just let me know please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is to reference the original source, since it's where the theme is developed/etc, I'd really expect the neovim itself to be the source though, to some extent...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the theme name simply references Nvim, but doesn't actually come from it. The source of the colors seem to come from iTerm itself:

https://raw.githubusercontent.com/mbadolato/iTerm2-Color-Schemes/master/schemes/NvimLight.itermcolors


[colors.primary]
background = '#14161b'
foreground = '#e0e2ea'

[colors.cursor]
text = '#14161b'
cursor = '#9b9ea4'

[colors.selection]
background = '#4f5258'
foreground = '#e0e2ea'

[colors.normal]
black = '#07080d'
red = '#ffc0b9'
green = '#b3f6c0'
yellow = '#fce094'
blue = '#a6dbff'
magenta = '#ffcaff'
cyan = '#8cf8f7'
white = '#eef1f8'

[colors.bright]
black = '#4f5258'
red = '#ffc0b9'
green = '#b3f6c0'
yellow = '#fce094'
blue = '#a6dbff'
magenta = '#ffcaff'
cyan = '#8cf8f7'
white = '#eef1f8'
33 changes: 33 additions & 0 deletions themes/nvim_light.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Color theme ported from Ghostty NvimLight theme

[colors.primary]
background = '#e0e2ea'
foreground = '#14161b'

[colors.cursor]
text = '#e0e2ea'
cursor = '#9b9ea4'

[colors.selection]
background = '#9b9ea4'
foreground = '#14161b'

[colors.normal]
black = '#07080d'
red = '#590008'
green = '#005523'
yellow = '#6b5300'
blue = '#004c73'
magenta = '#470045'
cyan = '#007373'
white = '#eef1f8'

[colors.bright]
black = '#4f5258'
red = '#590008'
green = '#005523'
yellow = '#6b5300'
blue = '#004c73'
magenta = '#470045'
cyan = '#007373'
white = '#eef1f8'