Rewrite Offline Mode #1511
Merged
Rewrite Offline Mode #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byquanton
force-pushed
the
rewrite/offline-detection
branch
from
de501fb to
388c323
Compare
|
New To-Do: Make it possible to add a To-Do while the server is offline. Maybe add an icon behind tasks when changes aren't synchronized yet |
byquanton
commented
Jan 15, 2025
alainm23
approved these changes
Jan 18, 2025
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the current online detection and replaces it with a callback that shows the user when a connection to a server couldn't be made.
Would fix the following issue: #1489
Things left to-do in the current implementation:
Make it possible to add to-dos offline-> Create a new PR for thisIf you have any feedback about this PR, please let me know.