Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16 inference pipeline for baskerville #29

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

16 inference pipeline for baskerville #29

wants to merge 27 commits into from
+1,159 −467

Conversation

J-Dymond
Copy link
Collaborator

This branch adds:

  • Single component version of the pipeline
  • Inference scripts which loop over entire dataset and save confidence measures and errors for all inputs
  • Tests for the pipelines to ensure correct inputs are being passed to each pipeline stage
  • Some utility functions for inference

@J-Dymond
barebones inference script, which loads data and pipeline
ca8fda1
@J-Dymond
updated the pre-commit-config to ignore untyped imports
89a6efd
@J-Dymond
barebones inference script, takes config and runs inference on valida…
40fe1aa 
…tion set. Doesn't currently save results
@J-Dymond
renamed inference script to reflect usage on whole pipeline, fixed da…
3f6ed42 
…taset utils so that unused column is dropped from the dataset
@J-Dymond
starting single component inference
4d24122
@J-Dymond
created single component inference pipeline, inherits from main pipel…
d9b2b9b 
…ine class. Need to create a results analysis function.
@J-Dymond
single component inference is set up to run and save outputs
cd62edf
@J-Dymond
removed break in inference loop and removed print statement
b95943b
@J-Dymond
Merge branch 'main' into 16-inference-pipeline-for-baskerville
5f6944e
@J-Dymond
removed test_base since we now have actual tests, starting to write t…
784d44c 
…he inference pipeline tests.
@J-Dymond
added some tests to ensure correct inputs are being passed during cle…
91b3c9f 
…an_inference
@J-Dymond
added test to check single component pipeline inference inputs
e6aa37e
@J-Dymond
updated single component error msg when invalid argument passed
ae791e7
@J-Dymond
Merge branch 'main' into 16-inference-pipeline-for-baskerville
504009f
@J-Dymond
added some comments to the single component pipeline
9de6d44
@J-Dymond J-Dymond linked an issue Nov 26, 2024 that may be closed by this pull request
Inference Pipeline for Baskerville #16
Open
@J-Dymond J-Dymond marked this pull request as ready for review November 26, 2024 18:37
lannelin
lannelin requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@lannelin lannelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one. I've made a few small requests for changes and left a few qs. Happy to discuss.

config/RTC_configs/bert-mt5-bert.yaml Outdated Show resolved Hide resolved
scripts/pipeline_inference.py Outdated Show resolved Hide resolved
scripts/single_component_inference.py Outdated Show resolved Hide resolved
src/arc_spice/eval/inference_utils.py Outdated Show resolved Hide resolved
src/arc_spice/eval/inference_utils.py Show resolved Hide resolved
src/arc_spice/eval/inference_utils.py Outdated Show resolved Hide resolved
src/arc_spice/variational_pipelines/utils.py Show resolved Hide resolved
src/arc_spice/variational_pipelines/utils.py Outdated Show resolved Hide resolved
src/arc_spice/variational_pipelines/RTC_single_component_pipeline.py Outdated Show resolved Hide resolved
src/arc_spice/variational_pipelines/utils.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddableheath eddableheath Awaiting requested review from eddableheath

@lannelin lannelin Awaiting requested review from lannelin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inference Pipeline for Baskerville
2 participants
@J-Dymond @lannelin