Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Update Identifier" logic is now aware of claim parents #540

Merged

Conversation

cptanalatriste
Copy link
Collaborator

The algorithm now has the following considerations, regarding top-level property claims (i.e. children of the goal of a strategy):

  • Property claim under goals, always have a lower identifier than property claims under strategies: In the current version of the TEA platform, property claims are always placed to the left of strategies. When issue [BUG] Top-level Strategies should be to the left of top-level Claims #539 is delivered, we'll need to change this logic.
  • Property claims from different strategies have their identifiers reflecting their parents (i.e. property claims under S1, will have identifiers inferior to the claims under S2.
  • The rest of the logic remains the same, where we sort by order of insertion.

@cptanalatriste cptanalatriste merged commit 81d9eba into develop Jul 10, 2024
8 checks passed
Copy link

Pull Request Test Coverage Report for Build 9877325292

Details

  • 80 of 85 (94.12%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 86.479%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/view_utils.py 60 65 92.31%
Totals Coverage Status
Change from base Build 9874417770: 0.2%
Covered Lines: 1970
Relevant Lines: 2278

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant