Quiet execution of ExtractArticle.js #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this @nelson-liu ? |
nelson-liu
suggested changes
Feb 13, 2023
Co-authored-by: Nelson Liu <[email protected]>
jemrobinson
approved these changes
Sep 4, 2024
jemrobinson
merged commit 41d47eb
into
alan-turing-institute:master
0 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling ExtractArticle.js on a "broken" site can cause node to write a lot of error and warning messages to stdout.
Because the output gets ignored anyway it might make more sense for it to be not printed out either otherwise
it becomes a problem for log collection and CLI applications.
Opinions?