-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyTorch model extractor #298
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 94.20% 94.22% +0.02%
==========================================
Files 62 63 +1
Lines 3606 3691 +85
==========================================
+ Hits 3397 3478 +81
- Misses 209 213 +4 ☔ View full report in Codecov by Sentry. |
Thanks a lot for this PR Martin. It looks great. Would this functionality be necessary if we change everything to PyTorch? is this a temporary measure until we do ? |
@marjanfamili, I think it wouldn't be necessary if everything is changed to PyTorch! So, yes, temporary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks
adds a function to extract PyTorch models from
AutoEmulate
emulatorsemulators can be
pipelines
,MultiOutputRegressors
etc., this function checks all the options and extracts the underlying PyTorch model where possible and throws an error for other modelsit also gives a message saying that datapreprocessing is better turned off when doing this and has to be done manually (as it can't be attached to the
PyTorch
model like it can be to asci-kit learn
model using apipeline
it returns the model in
eval
modedoes not yet include other objects as discussed in Add "fit only pytorch models" flag #291 . Maybe we leave that to the next PR?