Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add content to reproducibility page #183

Merged
merged 8 commits into from
Nov 27, 2024
Merged

docs: add content to reproducibility page #183

merged 8 commits into from
Nov 27, 2024

Conversation

andrewphilipsmith
Copy link
Collaborator

@andrewphilipsmith andrewphilipsmith commented Nov 15, 2024 •
edited
Loading

The PR adds a description of how we used clim-recal to produce the published data files.

@andrewphilipsmith andrewphilipsmith marked this pull request as ready for review November 20, 2024 16:55
@sgreenbury
Copy link
Collaborator

Looks good to me, thanks @andrewphilipsmith - I added a few small suggestions above and perhaps the _quarto.yml file also needs to be updated for rendering and referencing?

andrewphilipsmith and others added 2 commits November 22, 2024 16:43
@andrewphilipsmith @sgreenbury
Apply suggestions from code review to generate_trailing_checksums.sh
5c763a5 
Adds a few minor tweaks in the `bash/generate_trailing_checksums.sh` script.

Co-authored-by: Sam Greenbury <[email protected]>
@andrewphilipsmith @sgreenbury
Fixes typos in docs/reproducibility.qmd
faf5c7e 
Co-authored-by: Sam Greenbury <[email protected]>
@andrewphilipsmith
Copy link
Collaborator Author

Thanks @sgreenbury.

PR #182 updates _quarto.yml. Are additional changes required for this PR?

@andrewphilipsmith
Copy link
Collaborator Author

PR #182 updates _quarto.yml. Are additional changes required for this PR?

Just spotted that I need to add in docs/reproducibility.qmd to the sidebar in _quarto.yml. Will do that shortly.

sgreenbury
sgreenbury approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@sgreenbury sgreenbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to merge with _quarto.yml to be updated in #182.

@andrewphilipsmith
Copy link
Collaborator Author

I've updated _quarto.yml in this commit. This is part of #182, to save having merge conflicts when merging the two branches into main.

@RuthBowyer
Update reproducibility.qmd
f535ce6 
Just a few typos
RuthBowyer
RuthBowyer reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@RuthBowyer RuthBowyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy looks great! Happy to go with your preference re that comment I left on the HADs files

@andrewphilipsmith
Removes checksum for HAD Jan - Nov 1980
1485359 
This is to match the time span for the CPM data which starts in Dec 1980.
@andrewphilipsmith andrewphilipsmith merged commit 2738c5e into main Nov 27, 2024
2 checks passed
@andrewphilipsmith andrewphilipsmith deleted the add-reproducibility-page branch November 27, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuthBowyer RuthBowyer RuthBowyer left review comments

@sgreenbury sgreenbury sgreenbury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewphilipsmith @sgreenbury @RuthBowyer