Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'Internet' for data providers IP #2247

Draft
wants to merge 4 commits into
base: latest
Choose a base branch
from

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

#2246

⤴️ Summary

Allows data providers (as well as research users) IP addresses to be defined as the Azure service tag 'Internet'.

🌂 Related issues

🔬 Tests

Copy link

github-actions bot commented Oct 21, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  config.py
  data_safe_haven/config
  config_sections.py
  data_safe_haven/infrastructure/programs/sre
  networking.py 71-76
  data_safe_haven/logging
  plain_file_handler.py
  data_safe_haven/types
  enums.py
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge JimMadge mentioned this pull request Oct 21, 2024
3 tasks
@JimMadge JimMadge marked this pull request as ready for review October 21, 2024 15:29
@JimMadge JimMadge requested review from a team as code owners October 21, 2024 15:29
@JimMadge JimMadge marked this pull request as draft October 22, 2024 09:50
@JimMadge
Copy link
Member Author

This might be a bit more tricky as storage accounts use IP address ranges and not service tags for restricting external access.

It is possible to allow connection from any network.

@JimMadge JimMadge added this to the Release 5.0.1 milestone Oct 22, 2024
@JimMadge JimMadge added the release: non-essential Issues that at not essential to close for a release label Oct 22, 2024
Base automatically changed from release-v5.0.1rc1 to latest October 24, 2024 12:28
@JimMadge JimMadge modified the milestones: Release 5.0.1, Release 5.0.2 Oct 24, 2024
@JimMadge JimMadge removed the release: non-essential Issues that at not essential to close for a release label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant