Refactor node features ✍️ #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinaUlicna
added
the
documentation
|
Changed base to separate-inference to see actual changes, needs to be changed back to develop before merge. |
KristinaUlicna
changed the base branch from
separate-inference
to
development
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contribution summary
Why is this PR useful / good for? Please describe the problem(s) you're trying to address.
NODE_FEATURESto:NODE_IMG_EMBEDDINGto signify that this is the latent embedding of the underlying node image patchNODE_ENV_EMBEDDINGto suggest that this is the representation of the immediate environment of the node from the neighbourhood (multiplication by graph's Laplacian matrix)What should a reviewer concentrate their feedback on?
grace/base.py, no vigorous checks needed 😁What type of PR is this? (check all applicable)
Added tests?