Style checks and fixes #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seq_len instead of 1:length variable name lengths snake case names remove unused vars
seq_len incorrectly find/replaced function names
unused and incorrectly named arguments
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 82.49% 78.84% -3.66%
==========================================
Files 12 12
Lines 1114 1210 +96
==========================================
+ Hits 919 954 +35
- Misses 195 256 +61
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an actions workflow for
lintrandstylerand makes changes to fix style errors picked up by those libraries.Note: Also removes some commented code and a few unused variables/functions.
Quality check workflow passes on this branch (build fails for the same reasons as current master).