Status api versions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iain-S
force-pushed
the
status-api-versions
branch
from
ee7572c to
3993643
Compare
Iain-S
force-pushed
the
status-api-versions
branch
from
3993643 to
a58be53
Compare
Iain-S
force-pushed
the
status-api-versions
branch
from
a58be53 to
36ad1c4
Compare
dlpbc
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the newer API versions (e.g. the one we're dealing with as of the recent dependency updates), we need to call
auth_client.role_assignments.list_for_subscription()instead ofauth_client.role_assignments.list().Detail
The
azure.mgmt.authorization import AuthorizationManagementClientdecides dynamically what version ofrole_assignmentsit will return based on the api_version passed to the constructor or else a default. This makes it hard for type-checkers to pick up on the change.This PR:
2022-04-01. There is nothing special about it other than it seems to be the latest stable version.MODELS_MODULE.RoleAssignment()MagicMock(spec=OPERATIONS_MODULE.RoleAssignmentsOperations)