Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulumi for hackweek #148

Merged
merged 31 commits into from
Jan 15, 2024
Merged

Pulumi for hackweek #148

merged 31 commits into from
Jan 15, 2024

Conversation

rchan26
Copy link
Collaborator

@rchan26 rchan26 commented Jan 4, 2024

Towards #113 and #127

Renamed 'production' stack to 'hackweek'. Changes:

  • One container for Reggie Handbook, another for Reginald (llama-index-azure-gpt chat model on public indices)
  • Updated README for using pulumi for Add better README for pulumi stuff #133
  • Create another container for creating the public indices
  • Add automation account creation for turning on and off the container

Edit: I've also merged in pulumi-production here from #147 which renames the 'api-bot' stack to 'production'. This might seem confusing, but I think 'production' should refer to our main model which now the 'api-bot' and so that requires renaming the previous 'production' to 'hackweek'.

Similarly, updates to that model are:

  • One container for Reginald slack model which uses the model to link to some VM with an API
  • Create another container for creating the public indices
  • Add automation account creation for turning on and off the container

Note that on the Azure container instances, we seem to get httpx.ConnectTimeout errors but not locally. Something to figure out in the future.

The PR also includes a few important dependency updates - the hardest being was to update openai to 1.6.1 from 0.2.7. Needed a few small changes to update llama-index too.

@rchan26 rchan26 marked this pull request as draft January 4, 2024 14:11
@rchan26 rchan26 marked this pull request as ready for review January 11, 2024 09:34
@rchan26 rchan26 requested a review from rwood-97 January 11, 2024 09:35
@rwood-97
Copy link
Contributor

Potential problem for users without prior access to the keyvault:

ERROR: (Forbidden) The user, group or application 'appid=04b07795-8ddb-461a-bbee-02f9e1bf7b46;oid=0fa34a95-4888-4614-9810-e912eb316082;numgroups=20;iss=https://sts.windows.net/4395f4a7-e455-4f95-8a9f-1fbaef6384f9/' does not have keys create permission on key vault 'kv-reginald-hackweek;location=uksouth'. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125287
Code: Forbidden
Message: The user, group or application 'appid=04b07795-8ddb-461a-bbee-02f9e1bf7b46;oid=0fa34a95-4888-4614-9810-e912eb316082;numgroups=20;iss=https://sts.windows.net/4395f4a7-e455-4f95-8a9f-1fbaef6384f9/' does not have keys create permission on key vault 'kv-reginald-hackweek;location=uksouth'. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125287
Inner error: {
    "code": "AccessDenied"
}

Fix for now is for someone with access to add new users.

Copy link
Contributor

@rwood-97 rwood-97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay all seems to be working now, do you want to test one last time and then merge?

@rchan26
Copy link
Collaborator Author

rchan26 commented Jan 15, 2024

thanks a lot @rwood-97 for your changes. will merge now!

@rchan26 rchan26 merged commit 7c7f014 into main Jan 15, 2024
1 check passed
@rchan26 rchan26 deleted the pulumi-hackweek branch January 15, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants