Proposal: Outsource installation of packages (models, data plugins) - WARNING - breaking API change #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253 (see discussion on this issue)
Idea here is to circumvent a lot of the problems we have around package installation for models in the catalog (and more recently data plugins) by completely removing this as a feature of scivision. This branch does that, and I've created a branch on the
scivision_examples
repo with the same name that updates the intro (Koala) notebook (see here) - take a look under the "Loading the model" header.Essentially we raise a warning if the package is not installed that explains how to install it (we already had this warning in place in fact!).
I want to spark some discussion here, so feel free to voice your disagreements in the comments below!
TODO:
Further idea
Perhaps there should be a function like:
get_install_code('scivision_classifier')
which simply prints out:
... or alternatively links to the package repo README for packages that are more complex to install