Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/26 root event date #49

Merged
merged 19 commits into from
Oct 16, 2023
Merged

Feat/26 root event date #49

merged 19 commits into from
Oct 16, 2023

Conversation

thobson88
Copy link
Collaborator

@thobson88 thobson88 commented Sep 29, 2023

Closes #26.

Replaces the "Root event time" parameter in Settings with a "Root event date" plus a confirmation code to uniquely identify the transaction that commits to the root DID. However the rootEventTime field in the ConfigModel is preserved (it is determined as the timestamp of the root transaction, instead of being set explicitly by the user), so any logic that depends on it will not be affected.

Includes HTTP API calls that depend on the server updates in trustchain PR #125.

Copy link
Collaborator

@sgreenbury sgreenbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sgreenbury sgreenbury merged commit 66e84b1 into dev Oct 16, 2023
@sgreenbury sgreenbury deleted the feat/26-root-event-date branch October 16, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root event time as date
2 participants