Add data credential signing & verification to the CLI #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
reviewed
Sep 6, 2024
sgreenbury
force-pushed
the
181-credentials4data
branch
from
0e6b1a8
to
10b338f
Compare
sgreenbury
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Looks great and passes all expected tests (see #195), including ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181.
Adds a new
datasubcommand to the CLI. This is similar to thevcsubcommand, but instead for signing and verifying a credential for a data file.Note that the SHA-256 hashing algorithm is used (implicitly) to compute the hash identifier for the dataset, e.g.:
Ideally we should make this choice of hash function explicit, but it's unclear (to me) where this information belongs inside the credential.
(There are also some calls to
unwrap()that need to be fixed before merging.)