Skip to content

Commit

Permalink
[ 7274] Replace plugin-specific auth configs with general one
Browse files Browse the repository at this point in the history 
The plugin-specific auth configurations (authentication::pam_password
and authentication::native) have been replaced by a general config
for all auth schemes. The string in R_GRID_CONFIGURATION is now just
"authentication".
  • Loading branch information
@alanking
alanking committed Sep 29, 2023
1 parent a802b08 commit d036bb8
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 20 deletions.
10 changes: 4 additions & 6 deletions plugins/database/src/db_plugin.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6596,9 +6596,7 @@ irods::error db_check_auth_op(
expireTime = atoll( goodPwExpiry );
getNowStr( myTime );

/* Check for PAM_AUTH type passwords */

if (const auto err = get_auth_config("authentication::pam_password", ac); !err.ok()) {
if (const auto err = get_auth_config("authentication", ac); !err.ok()) {
log_db::error("Failed to get auth configuration. [{}]", err.result());
return err;
}
Expand Down Expand Up @@ -7095,7 +7093,7 @@ irods::error db_make_limited_pw_op(
getNowStr( myTime );

auth_config ac{};
if (const auto err = get_auth_config("authentication::native", ac); !err.ok()) {
if (const auto err = get_auth_config("authentication", ac); !err.ok()) {
log_db::error("Failed to get auth configuration. [{}]", err.result());
return err;
}
Expand Down Expand Up @@ -7235,7 +7233,7 @@ auto db_update_pam_password_op(irods::plugin_context& _ctx,
getNowStr( myTime );

auth_config ac{};
if (const auto err = get_auth_config("authentication::pam_password", ac); !err.ok()) {
if (const auto err = get_auth_config("authentication", ac); !err.ok()) {
log_db::error("Failed to get auth configuration. [{}]", err.result());
return err;
}
Expand Down Expand Up @@ -7573,7 +7571,7 @@ irods::error db_mod_user_op(

if ( strncmp( _option, "rmPamPw", 9 ) == 0 ) {
auth_config ac{};
if (const auto err = get_auth_config("authentication::pam_password", ac); !err.ok()) {
if (const auto err = get_auth_config("authentication", ac); !err.ok()) {
log_db::error("Failed to get auth configuration. [{}]", err.result());
return err;
}
Expand Down
4 changes: 2 additions & 2 deletions scripts/irods/database_upgrade.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,10 @@ def run_update(irods_config, cursor):
'password_max_time': str(pam_password_config.get('password_max_time', 1209600))
}

scheme_namespaces = ['authentication::pam_password', 'authentication::native']
scheme_namespaces = ['authentication']
statement_str = "insert into R_GRID_CONFIGURATION (namespace, option_name, option_value) values ('{}','{}','{}');"
# pam_password configurations for password lifetime have always been used with native authentication as well.
# The configurations are now separately configurable.
# The new configurations shall continue to configure both schemes, but under a more generic namespace.
for scheme in scheme_namespaces:
for option in password_config_dict:
database_connect.execute_sql_statement(cursor, statement_str.format(scheme, option, password_config_dict[option]))
Expand Down
24 changes: 12 additions & 12 deletions scripts/irods/test/test_iadmin_set_grid_configuration.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_nonexistent_namespace(self):
f'Failed to get grid configuration for namespace [{bad_namespace}] and option [{option_name}] [ec=-808000]')

def test_no_option_name(self):
namespace = 'authentication::native'
namespace = 'authentication'
self.admin.assert_icommand(
['iadmin', 'get_grid_configuration', namespace],
'STDERR', 'Error: option name must be between 1 and 2699 characters.')
Expand All @@ -51,23 +51,23 @@ def test_really_long_option_name(self):
# The input buffer to set_grid_configuration_value API is only 2700 characters long. If a value of 2700
# characters or more is fed to the input struct for the set_pam_password_config API, packstruct gives an error.
# iadmin will catch this case and show a slightly more presentable error, which is checked in this test.
namespace = 'authentication::native'
namespace = 'authentication'
really_long_option_name = 'this_is_27_characters_long_' * 100

self.admin.assert_icommand(
['iadmin', 'set_grid_configuration', namespace, really_long_option_name],
'STDERR', 'Error: option name must be between 1 and 2699 characters.')

def test_nonexistent_option_name(self):
namespace = 'authentication::native'
namespace = 'authentication'
bad_option_name = 'nopes'

self.admin.assert_icommand(
['iadmin', 'get_grid_configuration', namespace, bad_option_name], 'STDERR',
f'Failed to get grid configuration for namespace [{namespace}] and option [{bad_option_name}] [ec=-808000]')

def test_get_grid_configuration_valid(self):
namespace = 'authentication::native'
namespace = 'authentication'
option_name = 'password_max_time'

# Assert that a value is returned and that there are no errors.
Expand Down Expand Up @@ -112,7 +112,7 @@ def test_nonexistent_namespace(self):
f'Failed to set grid configuration for namespace [{bad_namespace}] and option [{option_name}] [ec=-808000]')

def test_no_option_name(self):
namespace = 'authentication::native'
namespace = 'authentication'
self.admin.assert_icommand(
['iadmin', 'set_grid_configuration', namespace],
'STDERR', 'Error: option name must be between 1 and 2699 characters.')
Expand All @@ -121,7 +121,7 @@ def test_really_long_option_name(self):
# The input buffer to set_grid_configuration_value API is only 2700 characters long. If a value of 2700
# characters or more is fed to the input struct for the set_pam_password_config API, packstruct gives an error.
# iadmin will catch this case and show a slightly more presentable error, which is checked in this test.
namespace = 'authentication::native'
namespace = 'authentication'
really_long_option_name = 'this_is_27_characters_long_' * 100
option_value = '1000'

Expand All @@ -130,7 +130,7 @@ def test_really_long_option_name(self):
'STDERR', 'Error: option name must be between 1 and 2699 characters.')

def test_nonexistent_option_name(self):
namespace = 'authentication::native'
namespace = 'authentication'
bad_option_name = 'nopes'
option_value = '1000'

Expand All @@ -139,14 +139,14 @@ def test_nonexistent_option_name(self):
f'Failed to set grid configuration for namespace [{namespace}] and option [{bad_option_name}] [ec=-808000]')

def test_no_option_value(self):
namespace = 'authentication::native'
namespace = 'authentication'
option_name = 'password_max_time'
self.admin.assert_icommand(
['iadmin', 'set_grid_configuration', namespace, option_name],
'STDERR', 'Error: option value must be between 1 and 2699 characters.')

def test_really_long_option_value(self):
namespace = 'authentication::native'
namespace = 'authentication'
option_name = 'password_max_time'

# The input buffer to set_grid_configuration_value API is only 2700 characters long. If a value of 2700
Expand All @@ -167,7 +167,7 @@ def test_really_long_option_value(self):
self.admin.assert_icommand(['iadmin', 'get_grid_configuration', namespace, option_name], 'STDOUT')[1])

def test_set_grid_configuration_valid(self):
namespace = 'authentication::native'
namespace = 'authentication'
option_name = 'password_max_time'

original_value = self.admin.assert_icommand(
Expand All @@ -188,7 +188,7 @@ def test_set_grid_configuration_valid(self):
self.admin.run_icommand(['iadmin', 'set_grid_configuration', namespace, option_name, original_value])

def test_set_invalid_grid_configuration_with_option_name_that_is_protected_in_another_namespace(self):
namespace = 'authentication::native'
namespace = 'authentication'
option_name = 'schema_version'

# Make sure this namespace doesn't have the option_name used in the test...
Expand Down Expand Up @@ -274,7 +274,7 @@ def test_set_delay_server_namespace_is_protected_even_with_invalid_option_name(s

def test_set_delay_server_namespace_is_protected_even_with_option_name_from_unprotected_namespaces(self):
namespace = 'delay_server'
other_namespace = 'authentication::native'
other_namespace = 'authentication'
option_name = 'password_max_time'
option_value = 'shenanigans!'

Expand Down

0 comments on commit d036bb8

Please sign in to comment.