Attempt to make fill and colour match

alanocallaghan · Jun 4, 2024 · b79c45b · b79c45b
1 parent 096e367
commit b79c45b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/R/plot_central.R b/R/plot_central.R
@@ -249,8 +249,8 @@ NULL
             }
         }
         plot_out <- .resolve_plot_colours(
-            plot_out, object$colour_by, colour_by, fill = point_out$fill,
-            colour = !point_out$fill, do_bin = !is.null(bins)
+            plot_out, object$colour_by, colour_by, fill = !is.null(fill_by) || point_out$fill,
+            colour = !is.null(colour_by), do_bin = !is.null(bins)
         )
     }
 

diff --git a/R/plot_colours.R b/R/plot_colours.R
@@ -45,7 +45,6 @@
     }
     # Picking whether to fill or not.
     aesthetics <- c("fill", "colour")[c(fill, colour)]
-
     if (fill) {
         VIRIDFUN <- scale_fill_viridis
         SCALEFUN <- scale_fill_manual