Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync the package with the most recent developments in packages SparseArray and DelayedArray #210

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

hpages
Copy link
Contributor

@hpages hpages commented Jul 17, 2024

Hi @alanocallaghan,

Even though scater 1.33.2 is mostly green on the BioC 3.20 daily build report, a few things are out of date with the current devel versions of SparseArray and DelayedArray. In particular:

  • SparseArraySeed objects are deprecated in DelayedArray >= 0.31.5;
  • Sparse blocks are now returned as SparseArray derivatives (either as COO_SparseArray or SVT_SparseArray objects). The latter support many operations (e.g. [, colSums(), colMeans(), etc...) very efficiently, and, for almost all the operations that they support, SVT_SparseArray objects outperform dgCMatrix objects. So most of the time it's preferrable to coerce to SVT_SparseArray than to dgCMatrix.

This patch removes references to the SparseArraySeed class and takes advantage of the efficiency of SVT_SparseArray objects. It also updates a few outdated importFrom statements.

Let me know if you have questions.

Best,
H.

@alanocallaghan alanocallaghan merged commit 7091047 into alanocallaghan:devel Jul 17, 2024
1 check passed
@alanocallaghan
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants