add LazyCacheOptions and use Options Pattern #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdurrahman
reviewed
Nov 18, 2023
| this.cacheProvider = new Lazy<ICacheProvider>(() => cacheProvider); | ||
| keyLocks = new int[_options.NumberOfKeyLocks]; | ||
| DefaultCachePolicy.DefaultCacheDurationSeconds = _options.DefaultCacheDurationSeconds; | ||
|
|
There was a problem hiding this comment.
Minor Suggestion: Consider removing this redundant empty line for cleaner code presentation.
| { | ||
| public int DefaultCacheDurationSeconds { get; set; } = 60 * 20; | ||
| public int NumberOfKeyLocks { get; set; } = Math.Max(Environment.ProcessorCount * 8, 32); | ||
|
|
There was a problem hiding this comment.
Minor Suggestion: Consider removing this redundant empty line for cleaner code presentation.
| public int NumberOfKeyLocks { get; set; } = Math.Max(Environment.ProcessorCount * 8, 32); | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
Including an empty line at the end of a file ensures consistency in version control diffs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a constructor dependency on IOptions options
base on #128