Skip to content

Commit

Permalink
Updated windows build action docs
Browse files Browse the repository at this point in the history
  • Loading branch information
albbus-stack committed May 24, 2024
1 parent 27b4c85 commit f15923c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build Desktop App (Linux)
name: Build Desktop App (Linux - deb)

on:
# push:
Expand Down Expand Up @@ -66,4 +66,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: linux
path: dist/bundle/appimage/**/*
path: dist/bundle/deb/**/*
6 changes: 3 additions & 3 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Build Desktop App (Windows)

on:
# push:
# branches:
# - master
push:
branches:
- master
# pull_request:
# branches:
# - master
Expand Down
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,11 @@ DATABASE_URL
- To deploy the web app using Github Pages you have to choose in the repository settings under Pages the `gh-pages` branch. You should also set workflow permissions under the Actions settings to `Read and write permissions`.
- Change the `base_path` in the `Dioxus.pages.toml` file to match the name of your repository.
- Remember to deploy your api with `APP_URL` set to your Github Pages domain (e.g. `https://albbus-stack.github.io`) otherwise there will be CORS errors.
- Configure the `.github/workflows/deploy-web.yaml` workflow to deploy on every push to the `main` branch or manually with the `workflow_dispatch` event.
- Configure the `.github/workflows/deploy-web.yaml` workflow to deploy on every push to the `master` branch or manually with the `workflow_dispatch` event.

### Desktop

> Github actions for the Windows, Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
> Github actions for the Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails (this is not good since you need attach the `dist` folder to your release to include your assets).
- For Windows you can configure the `.github/workflows/windows.yaml` workflow to build and upload the `.msi` installer in the action artifacts on every push to the `master` branch or manually with the `workflow_dispatch` event.
- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails on other platforms (this is not good since you need attach the entire `dist` folder to your release build).

0 comments on commit f15923c

Please sign in to comment.