Reset all attributes after colorization #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -955,7 +955,7 @@ static protected function _colorize($string, $color = null) | |||
| return $string; | |||
| } | |||
|
|
|||
| $string = "\033[{$colorNumber}m" . $string . "\033[39m"; | |||
| $string = "\033[{$colorNumber}m" . $string . "\033[0m"; | |||
There was a problem hiding this comment.
Thank you for pointing this out.
The problem with this is that background color will also be reset. I've changed the escape code to "\033[39;0m" which will reset bold state aswell. Let me know if this does the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code 39 only resets the color to the default one, which leaves part of strings bold after using light_* colors.