Google Auth Provider #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moekarakii
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Good job on the.eslintrc.js and .gitignore files for consistency/efficiency across the whole project. I see you worked on Including the google sign-In functionality with react native's google auth. Added support for expo secure storage. Updated _layout.tsx to use SessionProvider and Slot, which makes it easier to read/understand, in my opinion. Lastly, the new screens (profile.tsx and auth.tsx) with clean and structured code.
however, it seems there are some conflicts with files layout.tsx, package.json, and the yarn.lock
jameslindfors
force-pushed
the
3-lindfors-auth
branch
from
468a19c to
35b31bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #3
Implements sign in with google functionality with a reusable auth context provider that protects all the routes when not signed in. It also updates the .gitignore to include the .vscode files and build folders. It also adds and configures eslint.
Notes:
Because using the library requires a native module it cannot be run in the expo go application but the code must be built specifically for android using the following command:
npx expo run androidWarning:
When building on windows the build will fail from react-native-reanimated if the path is too long. To fix this, the local repo folder must be moved to a location with a shorter path. See issue here:
software-mansion/react-native-reanimated#6872