Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL Queries Feature Added #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

URL Queries Feature Added #13

wants to merge 2 commits into from

Conversation

adurhmn
Copy link

@adurhmn adurhmn commented Jul 10, 2024

Resolves Issue #12

albertodeago
albertodeago requested changes Jul 12, 2024
View reviewed changes
.gitignore
@@ -1,2 +1,3 @@
.DS_Store
node_modules
dist
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist is meant to be shipped.
If you want to ignore it, you'll need to change the build process, otherwise it won't be there when you uinstall it as a dependency

@albertodeago
Copy link
Owner

thanks @adurhmn for opening a PR to improve this package 🫶
I've just a comment as stated above, if you fix it (I suggest to just get rid of the dist in the gitignore) that'll be enough to merge it!
Keep in mind that you will also need to build the package locally (npm run build) and commit the dist changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertodeago albertodeago albertodeago requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adurhmn @albertodeago