Implement SSL #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argysamo
force-pushed
the
feature/support-ssl
branch
from
fda1fc6 to
54bcca8
Compare
|
FWIW the lint issue should go away if you rebase on main |
|
Introduce backwards compatible SSL. - [script.py] Add optional argument for ssl-private_key, ssl-public_key and ssl-ca - [web.py] Add optional ssl_context - [conftest.py] Pytest utilities to test ssl - [script_test.py/web_test.py] Add ssl testing
- [conftest.py]: Replace all `return` with `yield` statements - [pyproject.toml]: Add `trustme` as test dependency - [script.py]: `_configure_ssl` is now `_get_ssl_context` (not a staticmethod anymore). SSL arguments are of type `FileType` (not `str`). - [script_test.py]: Remove the `xfail` decorator - [web.py and script.py]: Replace `Optional` with `| None`
- args.FileType returns a FileType object. `load_cert_chain` expects public/private key paths as `str`. `name` attribute (of `FileType`) returns exactly what is needed.
- Sort imports
argysamo
force-pushed
the
feature/support-ssl
branch
from
3031e99 to
43a41ff
Compare
- [script.py]: Remove `from ssl import SSLContext` statement. Close ssl related FileType objects. - [README.rst]: Add references to the SSL arguments
argysamo
force-pushed
the
feature/support-ssl
branch
from
43a41ff to
8fc42fc
Compare
|
Thank you very much! |
|
Hello Alberto,
Thank you so much for you kind words and your PR feedback.
A question: Do you plan to create a new release of the latest changes? I’d love to use the ssl with your query-exporter.
Cheers,
Argyris
…--
Argyrios Samourkasidis
Αργύριος Σαμουρκασίδης
On 23 Oct 2023, at 22:37, Alberto Donato ***@***.***> wrote:
Thank you very much!
—
Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAHMKPAIQQVXQTANMFQQZ3YA3IQNAVCNFSM6AAAAAA6JPZSWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVHE4DAOJWGY>.
You are receiving this because you authored the thread.
|
|
I plan to make a 2.0 release soon which will also include the changes I made for |
|
thanks so much. Please let me know if there's anything I could help with! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce backwards compatible SSL.