-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random order #2023
Fix random order #2023
Conversation
Reviewer's Guide by SourceryThis PR improves the RandomOrder transform implementation by enhancing its documentation and making the Updated class diagram for RandomOrderclassDiagram
class RandomOrder {
+TransformsSeqType transforms
+int n = 1
+bool replace = False
+float p = 1.0
+_get_idx() np.ndarray[np.int_]
}
note for RandomOrder "The `n` parameter is now optional with a default value of 1."
note for RandomOrder "Enhanced documentation for better understanding of attributes."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
=========================================
+ Coverage 0 90.35% +90.35%
=========================================
Files 0 47 +47
Lines 0 7559 +7559
=========================================
+ Hits 0 6830 +6830
- Misses 0 729 +729 ☔ View full report in Codecov by Sentry. |
Fixes: #2021
Summary by Sourcery
Fix the random order of transformations in the RandomOrder class and enhance its documentation. Update pre-commit configuration to use newer versions of ruff and pyproject-fmt.
Bug Fixes:
Enhancements:
Build: