Fix elastic

[ternaus]

Summary by Sourcery

Bug Fixes:

• Fix the generation of noise fields in the elastic transformation by ensuring Gaussian and uniform distributions are handled correctly.

[sourcery-ai]

Reviewer's Guide by Sourcery

The PR refactors the noise field generation in the elastic transformation code by consolidating common operations and simplifying the logic flow. The changes maintain the same functionality while making the code more maintainable and reducing duplication.

Class diagram for generate_displacement_fields function refactor

classDiagram
    class generate_displacement_fields {
        +generate_noise_field() np.ndarray
    }

    class generate_noise_field {
        +generate_noise_field() np.ndarray
        +noise_distribution: String
        +random_generator: RandomGenerator
        +image_shape: Tuple
        +kernel_size: Tuple
        +sigma: Float
        +alpha: Float
        +field: np.ndarray
    }

    generate_displacement_fields --> generate_noise_field

    note for generate_noise_field "Refactored to consolidate common operations and simplify logic flow."

Loading

File-Level Changes

Change	Details	Files
Refactored noise field generation function to reduce code duplication	Separated noise generation from post-processing steps Consolidated common operations (type conversion and Gaussian blur) into a single code path Simplified conditional logic for noise distribution types Removed redundant scaling operation for Gaussian distribution	albumentations/augmentations/geometric/functional.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

• The else clause should explicitly check for 'uniform' distribution to prevent silent failures if new distribution types are added in the future
• The gaussian normalization step (multiply by 2 and subtract 1) was removed, which means gaussian noise is no longer scaled to [-1, 1] range like the uniform distribution

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.33%. Comparing base (b1a79c2) to head (d011ee2).
Report is 248 commits behind head on main.

Files with missing lines	Patch %	Lines
...bumentations/augmentations/geometric/functional.py	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           main    #2049       +/-   ##
=========================================
+ Coverage      0   90.33%   +90.33%     
=========================================
  Files         0       46       +46     
  Lines         0     7596     +7596     
=========================================
+ Hits          0     6862     +6862     
- Misses        0      734      +734     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.