-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning in piecewise affine #2052
Conversation
Reviewer's Guide by SourceryThis PR fixes a warning message and simplifies code in the PiecewiseAffine transformation class. The changes include updating the name of a referenced transformation class in a warning message and improving code readability by reducing variable reassignment. Updated class diagram for PiecewiseAffine transformationclassDiagram
class PiecewiseAffine {
- p: float
- always_apply: bool
- nb_rows: tuple
- nb_cols: tuple
- scale: tuple
- absolute_scale: bool
+ get_transform_init_args_names() tuple[str, ...]
+ get_params_dependent_on_data(params: dict[str, Any], data: dict[str, Any]) dict[str, Any]
}
note for PiecewiseAffine "Updated warning message and variable assignment for image_shape"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
=========================================
+ Coverage 0 90.32% +90.32%
=========================================
Files 0 46 +46
Lines 0 7600 +7600
=========================================
+ Hits 0 6865 +6865
- Misses 0 735 +735 ☔ View full report in Codecov by Sentry. |
Fixes: #2051
Summary by Sourcery
Fix a warning message to suggest the correct alternative transformation and refactor variable assignment for better code clarity.
Bug Fixes:
Enhancements: