Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in piecewise affine #2052

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Nov 2, 2024

Fixes: #2051

Summary by Sourcery

Fix a warning message to suggest the correct alternative transformation and refactor variable assignment for better code clarity.

Bug Fixes:

  • Correct the warning message to suggest using 'ElasticTransform' instead of 'ElasticTransformation'.

Enhancements:

  • Refactor variable assignment for image shape to improve code clarity.

Copy link
Contributor

sourcery-ai bot commented Nov 2, 2024

Reviewer's Guide by Sourcery

This PR fixes a warning message and simplifies code in the PiecewiseAffine transformation class. The changes include updating the name of a referenced transformation class in a warning message and improving code readability by reducing variable reassignment.

Updated class diagram for PiecewiseAffine transformation

classDiagram
    class PiecewiseAffine {
        - p: float
        - always_apply: bool
        - nb_rows: tuple
        - nb_cols: tuple
        - scale: tuple
        - absolute_scale: bool
        + get_transform_init_args_names() tuple[str, ...]
        + get_params_dependent_on_data(params: dict[str, Any], data: dict[str, Any]) dict[str, Any]
    }
    note for PiecewiseAffine "Updated warning message and variable assignment for image_shape"
Loading

File-Level Changes

Change Details Files
Updated warning message to reference the correct transformation class name
  • Changed 'ElasticTransformation' to 'ElasticTransform' in the warning message
albumentations/augmentations/geometric/transforms.py
Simplified code in the get_params_dependent_on_data method
  • Removed unnecessary variable unpacking of height and width
  • Directly passed image_shape to create_piecewise_affine_maps function
albumentations/augmentations/geometric/transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (b1a79c2) to head (a0a015a).
Report is 250 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2052       +/-   ##
=========================================
+ Coverage      0   90.32%   +90.32%     
=========================================
  Files         0       46       +46     
  Lines         0     7600     +7600     
=========================================
+ Hits          0     6865     +6865     
- Misses        0      735      +735     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit eab8836 into main Nov 2, 2024
16 checks passed
@ternaus ternaus deleted the fix_warning_in_piecewise_affine branch November 2, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning: Try to use ElasticTransformation instead. However, there is no API for ElasticTransformation.
1 participant