Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pixel dropout #2280

Merged
merged 3 commits into from
Jan 18, 2025
Merged

Fix pixel dropout #2280

merged 3 commits into from
Jan 18, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 18, 2025

Fixes: #2279

Summary by Sourcery

Fix bugs related to the PixelDropout transform, including incorrect drop value handling for multi-channel images and per-channel dropout with sequence values.

Bug Fixes:

  • Fix incorrect drop value handling for multi-channel images in PixelDropout.
  • Fix per-channel dropout with sequence values in PixelDropout.

Tests:

  • Add tests for PixelDropout to verify correct drop value handling and per-channel dropout behavior.

Copy link
Contributor

sourcery-ai bot commented Jan 18, 2025

Reviewer's Guide by Sourcery

This pull request addresses an issue in the PixelDropout augmentation where the drop_value parameter was not being correctly applied when per_channel was set to True. The changes ensure that the drop_value is correctly applied per channel, and adds tests to verify the fix.

Class diagram for updated PixelDropout transform

classDiagram
    class PixelDropout {
        +dropout_prob: float
        +per_channel: bool
        +drop_value: ColorType
        +mask_drop_value: ColorType
        +p: float
        +__init__(dropout_prob: float, per_channel: bool, drop_value: ColorType, mask_drop_value: ColorType, p: float)
        +apply(img: ndarray, drop_mask: ndarray, drop_values: ndarray): ndarray
    }
    class DualTransform {
        <<parent>>
    }
    DualTransform <|-- PixelDropout
    note for PixelDropout "Changed drop_value and mask_drop_value
type from ScaleFloatType to ColorType
Removed per_channel restriction"
Loading

Flow diagram for pixel dropout process

flowchart TD
    A[Input Image] --> B{Per Channel?}
    B -->|Yes| C[Apply dropout per channel]
    B -->|No| D[Apply dropout globally]
    C --> E[Apply drop values per channel]
    D --> F[Apply single drop value]
    E --> G[Output Image]
    F --> G
Loading

File-Level Changes

Change Details Files
Fixed the application of drop_value in PixelDropout when per_channel is True.
  • Modified PixelDropout to correctly apply drop_value per channel when per_channel is True.
  • Updated prepare_drop_values to handle sequence drop_value for multichannel images.
  • Removed the restriction on mask_drop_value when per_channel is True.
albumentations/augmentations/transforms.py
albumentations/augmentations/functional.py
Added new tests to verify the fix for PixelDropout.
  • Added tests for different drop_value types (None, single value, sequence) when per_channel is False.
  • Added tests for drop_value with per_channel set to True, including single and sequence values.
  • Added a functional test to verify pixel_dropout with sequence values and per_channel=True.
tests/test_augmentations.py
tests/functional/test_functional.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

tests/test_augmentations.py Show resolved Hide resolved
tests/test_augmentations.py Show resolved Hide resolved
tests/functional/test_functional.py Show resolved Hide resolved
tests/functional/test_functional.py Show resolved Hide resolved
tests/test_augmentations.py Show resolved Hide resolved
tests/test_augmentations.py Show resolved Hide resolved
tests/test_augmentations.py Show resolved Hide resolved
tests/test_augmentations.py Show resolved Hide resolved
tests/test_augmentations.py Show resolved Hide resolved
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (b1a79c2) to head (622fc88).
Report is 380 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2280       +/-   ##
=========================================
+ Coverage      0   89.85%   +89.85%     
=========================================
  Files         0       50       +50     
  Lines         0     8818     +8818     
=========================================
+ Hits          0     7923     +7923     
- Misses        0      895      +895     
Flag Coverage Δ
ubuntu-py3.12 89.85% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit bd782dc into main Jan 18, 2025
16 checks passed
@ternaus ternaus deleted the fix_pixel_dropout branch January 18, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type of parameters to PixelDropout, disallowing per-channel values
1 participant