-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First commit #1
First commit #1
Conversation
Reviewer's Guide by SourceryThis pull request establishes a comprehensive benchmarking suite for comparing the performance of popular image augmentation libraries. The implementation includes a modular architecture for running benchmarks, collecting metrics, and generating comparison reports. The suite supports multiple libraries (Albumentations, imgaug, torchvision, Kornia, and Augly) and features adaptive warmup, statistical analysis, and thread control settings. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a LICENSE file to clarify the terms under which this benchmarking suite can be used and distributed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Introduce a benchmarking suite for image augmentation libraries, supporting Albumentations, imgaug, torchvision, Kornia, and Augly. Implement a BenchmarkRunner class to manage the benchmarking process, including adaptive warmup and variance stability checks. Add scripts for running benchmarks and generating comparison outputs. Set up CI for code formatting and type checking. Update README with detailed documentation.
New Features:
Enhancements:
Build:
CI:
Documentation:
Tests: