-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update benchmark #14
Update benchmark #14
Conversation
Reviewer's Guide by SourceryThis pull request updates the benchmark suite to include more transforms and use the latest versions of the libraries. The implementations of the transforms were updated to use the latest APIs and to ensure that the transforms are applied with a probability of 1.0. Class diagram showing the updated transform implementationsclassDiagram
class KorniaImpl {
+ColorJitter(params)
+AutoContrast(params)
+Blur(params)
+Brightness(params)
+ChannelDropout(params)
+ChannelShuffle(params)
+CLAHE(params)
+Contrast(params)
+Equalize(params)
+RandomGamma(params)
+GaussianBlur(params)
+GaussianNoise(params)
+Invert(params)
+Posterize(params)
+Solarize(params)
+Sharpen(params)
+Normalize(params)
+Erasing(params)
+OpticalDistortion(params)
+ThinPlateSpline(params)
}
class AlbumentationsImpl {
+Resize(params)
+RandomCrop128(params)
+HorizontalFlip(params)
+VerticalFlip(params)
+Rotate(params)
+Affine(params)
+Perspective(params)
+Elastic(params)
+ColorJitter(params)
+GaussianBlur(params)
+GaussianNoise(params)
+Normalize(params)
+Erasing(params)
}
class TorchvisionImpl {
+Resize(params)
+RandomCrop128(params)
+RandomResizedCrop(params)
+CenterCrop128(params)
+HorizontalFlip(params)
+VerticalFlip(params)
+Pad(params)
+Rotate(params)
+Affine(params)
+ColorJitter(params)
+GaussianBlur(params)
+Normalize(params)
}
note for KorniaImpl "Updated to use p=1 for all transforms"
note for AlbumentationsImpl "Updated to use latest APIs"
note for TorchvisionImpl "Added new transforms and updated APIs"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Tests: