Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try for run transforms #7

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ayasyrev
Copy link
Contributor

@ayasyrev ayasyrev commented Oct 29, 2024

If some transform on some image fail, all results for lib will be lost.

Summary by Sourcery

Bug Fixes:

  • Add exception handling to prevent loss of all results if a transform fails.

Copy link

sourcery-ai bot commented Oct 29, 2024

Reviewer's Guide by Sourcery

The PR implements error handling for transform operations by replacing a dictionary comprehension with a traditional for loop and try-except block. This change prevents the entire benchmark run from failing when a single transform operation fails.

Sequence diagram for error handling in transform operations

sequenceDiagram
    participant User
    participant Runner
    participant Transform
    User->>Runner: Initiate run
    loop For each spec in TRANSFORM_SPECS
        Runner->>Transform: run_transform(spec, images)
        alt Transform succeeds
            Transform-->>Runner: Return result
            Runner->>Runner: Store result in results
        else Transform fails
            Transform-->>Runner: Raise Exception
            Runner->>Runner: Log warning
        end
    end
    Runner-->>User: Return results
Loading

File-Level Changes

Change Details Files
Added error handling for transform operations
  • Replaced dictionary comprehension with explicit for loop
  • Added try-except block to catch exceptions during transform execution
  • Added warning message when a transform fails
benchmark/runner.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ayasyrev - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider tracking failed transforms in the results dictionary (e.g. as None or with an error message) rather than silently skipping them. This would make it clearer to users which transforms failed when analyzing the benchmark results.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

benchmark/runner.py Show resolved Hide resolved
@ternaus ternaus merged commit 04b92c4 into albumentations-team:main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants