Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #350 #355

Conversation

xiki-tempula
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (3cf7c25) to head (20d7655).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   98.82%   98.72%   -0.11%     
==========================================
  Files          28       28              
  Lines        1873     1875       +2     
  Branches      405      405              
==========================================
  Hits         1851     1851              
  Misses          2        2              
- Partials       20       22       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ckward_convergence-will-be-scaled-by-the-unit-converter-in-abfe-workflow
@orbeckst
Copy link
Member

orbeckst commented Apr 1, 2024

This branch also contains the versioneer updates from PR #354. Can you rebase or merge once that PR is merged to get a cleaner diff?

…ckward_convergence-will-be-scaled-by-the-unit-converter-in-abfe-workflow
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@orbeckst orbeckst enabled auto-merge (squash) April 1, 2024 08:39
@orbeckst orbeckst self-assigned this Apr 1, 2024
@orbeckst orbeckst merged commit 4e150f8 into master Apr 1, 2024
10 of 11 checks passed
@orbeckst orbeckst deleted the 350-the-data_fraction-column-in-forward_backward_convergence-will-be-scaled-by-the-unit-converter-in-abfe-workflow branch April 1, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The data_fraction column in forward_backward_convergence will be scaled by the unit converter in ABFE workflow
2 participants