EthTransmuterLooper Front End [WIP] #257
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ButlerATTS
commented
Nov 8, 2024
ButlerATTS
commented
- Added an initial front end based on gALCX
- Added contract ABIs for mainnet, arb, and op
- Added transmuter config objects for the looper vaults
- Added an initial front end based on gALCX - Added contract ABIs for mainnet, arb, and op - Added transmuter config objects for the looper vaults
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
t0rbik
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Overall good start!
Lmk if you have any particular questions and as I mentioned I'm down to elaborate on the EthTransmuterLooper component rewrite.
As I've sent in dms, try to install those extensions and you will probably (?) see some places turn red (in transmuter config and in looper component) - we want no red places and no any. I didn't put every place as there are more. Given you are in vscode, you can open terminal panel and select PROBLEMS tab. Let me know if your vscode still doesn't point at those issues.
- Removed unused contract ABIs - Removed reducer and watchEvent calls and replaced with watchQuery and a standard readContracts - Other minor adjustments like adding new types and addressing format/lint issues
t0rbik
requested changes
Nov 29, 2024
- Added useEnsoBundler and usePortal hooks to facilitate tx bundling - Implemented portal bundling into a stock erc4626 vault (yvUSDC) in place of the Looper contract on Arb for testing - Minor other changes, such as added constants for WETH on various L2s
t0rbik
reviewed
Dec 23, 2024
- Refactored the usePortal hooks and their implementation in the looper to better follow react conventions - Addressed recent PR comments for types, assertions, etc.
… enums to immutable constants
FEATURE-CHORE: Looper adjustments
…ic. Addressed TODOs
- Changed usePortal mutationCallback to use useWriteContractMutationCallback - Updated simulate hooks for depositConfig and redeemConfig to only be enabled based on currently selected asset and isWithdraw state - Replaced UI states shown through toasts to be shown as button states instead - Made the looper responsive - Fixed issue with responsiveness at 1024px on the gALCXWrapper component
* x * simplify * redeem, not withdraw
…n undefined default for useTokensQuery
…ress state var to avoid undefined comparisons
…updates FEAT: Looper suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.