Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transmuter Total Deposits Info #296

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Transmuter Total Deposits Info #296

merged 12 commits into from
Dec 5, 2024

Conversation

ButlerATTS
Copy link
Collaborator

Added a column for total Transmuter deposits on the TransmuterAccordion, and adjusted col classes used

t0rbik and others added 10 commits November 15, 2024 20:46
@t0rbik
Merge pull request #268 from alchemix-finance/staging
f06d72b 
CHORE: Staging
@t0rbik
Merge pull request #271 from alchemix-finance/staging
11e1464 
CHORE: Staging
@t0rbik
Merge pull request #273 from alchemix-finance/staging
a535ad0 
CHORE: Staging
@t0rbik
Merge pull request #276 from alchemix-finance/staging
9fada9e 
CHORE: Staging
@t0rbik
Merge pull request #282 from alchemix-finance/staging
4ed1638 
CHORE: Staging
@t0rbik
Merge pull request #286 from alchemix-finance/staging
3274fed 
HOTFIX: Staging
@t0rbik
Merge pull request #288 from alchemix-finance/staging
f08f4b9 
CHORE: Staging
@t0rbik
Merge pull request #290 from alchemix-finance/staging
48914b5 
CHORE: Staging
@t0rbik
Merge pull request #295 from alchemix-finance/staging
c241530 
CHORE: Staging
@ButlerATTS
Added a column for total Transmuter deposits on the TransmuterAccordi…
febc059 
…on, and adjusted col classes used
@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alchemix-v2-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:07pm

@t0rbik t0rbik self-requested a review December 4, 2024 19:29
@t0rbik
Copy link
Collaborator

t0rbik commented Dec 5, 2024

I went ahead and pushed refactored some code for consistency, because I already had it to see possible solutions (re: discord dms). Let me know if you disagree with this change!

  1. Span more space for first column to have TVL in one row. Responsive checked - looks good.
  2. Move formatNumber to output jsx for code consistency - reasoning is logic part stays in component function body and formatting in jsx.
  3. Changed formatNumber options to display compact number, removed dustToZero because we have this mainly for user deposits because it leaves some dust when one withdraws/migrates.
  4. Changed || to ?? to target only the case when left-side (decimals) is undefined. || is more common case, so not needed imo.

@t0rbik t0rbik changed the base branch from main to staging December 5, 2024 15:14
@t0rbik t0rbik merged commit ed5496e into staging Dec 5, 2024
3 checks passed
@t0rbik t0rbik deleted the feat/transmuter-total-deposits branch December 5, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0rbik t0rbik t0rbik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ButlerATTS @t0rbik