optimize sf voter

alchemy-fr · Aug 10, 2024 · a79f8df · a79f8df
1 parent d74d469
commit a79f8df
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/Security/Voter/AclVoter.php b/Security/Voter/AclVoter.php
@@ -21,6 +21,16 @@ protected function supports(string $attribute, mixed $subject): bool
         return is_numeric($attribute) && $subject instanceof AclObjectInterface;
     }
 
+    public function supportsAttribute(string $attribute): bool
+    {
+        return is_numeric($attribute);
+    }
+
+    public function supportsType(string $subjectType): bool
+    {
+        return is_a($subjectType, AclObjectInterface::class, true);
+    }
+
     protected function voteOnAttribute(string $attribute, mixed $subject, TokenInterface $token): bool
     {
         $user = $token->getUser();

diff --git a/Security/Voter/SetPermissionVoter.php b/Security/Voter/SetPermissionVoter.php
@@ -25,10 +25,27 @@ protected function supports(string $attribute, mixed $subject): bool
             $attribute, [
                 self::ACL_READ,
                 self::ACL_WRITE,
-            ]
+            ],
+                true
         ) && $subject instanceof AclObjectInterface;
     }
 
+    public function supportsAttribute(string $attribute): bool
+    {
+        return in_array(
+            $attribute, [
+                self::ACL_READ,
+                self::ACL_WRITE,
+            ],
+            true
+        );
+    }
+
+    public function supportsType(string $subjectType): bool
+    {
+        return is_a($subjectType, AclObjectInterface::class, true);
+    }
+
     /**
      * @param AclObjectInterface $subject
      */