-
Notifications
You must be signed in to change notification settings - Fork 6
chore: move all Footer icons to their own file #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌿 Documentation Preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Purpose: Extract inline footer SVG icons and the BuiltByFern component into separate, reusable components under a dedicated icons folder for better organization.
Key changes:
- Moved all inline SVG icon definitions from Footer.tsx into individual component files under components/icons.
- Extracted BuiltByFern into its own BuiltWithFern.tsx file and updated Footer.tsx to import all externalized assets.
- Simplified Footer.tsx header by replacing large inline SVG blocks with imports.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 13 comments.
Show a summary per file
File | Description |
---|---|
fern/components/Footer.tsx | Replaced large inline icon and BuiltByFern definitions with imports to newly created components. |
fern/components/BuiltWithFern.tsx | New component file for BuiltByFern; exports both named and default. |
fern/components/icons/AlchemyLogo.tsx | New standalone AlchemyLogo SVG component. |
fern/components/icons/AlchemyUniversityIcon.tsx | New standalone AlchemyUniversityIcon SVG component. |
fern/components/icons/DiscordIcon.tsx | New standalone DiscordIcon SVG component. |
fern/components/icons/EmailIcon.tsx | New standalone EmailIcon SVG component. |
fern/components/icons/NewsletterIcon.tsx | New standalone NewsletterIcon SVG component. |
fern/components/icons/RobotIcon.tsx | New standalone RobotIcon SVG component. |
fern/components/icons/StatusIcon.tsx | New standalone StatusIcon SVG component. |
fern/components/icons/SupportHubIcon.tsx | New standalone SupportHubIcon SVG component. |
fern/components/icons/XIcon.tsx | New standalone XIcon SVG component. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Tests using imports in custom MDX components
Related Issues
Changes Made
Testing
pnpm run validate
)