Allow controlling max manifests per content with env var #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting the max number of manifests per content piece during compaction using an env var.
ashmrtn
commented
Sep 5, 2024
|
|
||
| mgr := newManagerForTesting(ctx, t, data, ManagerOptions{}) | ||
| for _, test := range table { |
There was a problem hiding this comment.
simplest to view with whitespace disabled
pandeyabs
approved these changes
Sep 5, 2024
|
🤔 race detector tests failed in CI and locally when running the same command, but the reason they failed is |
Default to having the feature off if the env var isn't set or is set to a value that is <= 0. This makes things a bit safer since it requires explicit configuration to enable. Also be more careful about the types being used to contain values since we're parsing data from a string which may make different assumptions about integer widths. This also adds a layer of protection in some sense since values larger than maxInt64 will overflow to a negative value and result in the feature being disabled instead of writing out 1 manifest per content piece.
This should also fix race detector failures in CI since we no longer need to write out as many manifests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow adjustments to the max number of manifests per content piece through the use of an environment variable