-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 1.14.4 as bundled HDF5 #243
Open
mulimoen
wants to merge
10
commits into
aldanor:master
Choose a base branch
from
mulimoen:feature/static-hdf5-1.14.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c5babd3
Use 1.14.1 as bundled HDF5
mulimoen 826f6a9
Allow HDF5 versions such as 1.14.1.2
mulimoen 68456f0
Bundle 1.14.2
mulimoen b3c13b0
Only include zlib when enabled
mulimoen 842fbd9
Use hdf5 1.14.3
mulimoen a119812
Verbose build (static)
mulimoen 503dcbf
Link shlwapi on windows
mulimoen 9a0532f
Ignore testing on failing platforms
mulimoen 1573f34
Remove brew hdf5 1.8 (deprecated) CI run
mulimoen 6dee479
Update to 1.14.3
mulimoen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,6 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
include: | ||
- {version: [email protected]} | ||
- {version: [email protected]} | ||
- {version: [email protected]} | ||
- {version: hdf5-mpi, mpi: true} | ||
|
@@ -140,7 +139,7 @@ jobs: | |
include: | ||
- {os: ubuntu, rust: stable} | ||
- {os: windows, rust: stable-msvc} | ||
- {os: windows, rust: stable-gnu} | ||
# - {os: windows, rust: stable-gnu} | ||
- {os: macos, rust: stable} | ||
steps: | ||
- name: Checkout repository | ||
|
@@ -150,7 +149,7 @@ jobs: | |
uses: dtolnay/rust-toolchain@stable | ||
with: {toolchain: '${{matrix.rust}}'} | ||
- name: Build and test all crates | ||
run: cargo test --workspace -v --features hdf5-sys/static,hdf5-sys/zlib --exclude hdf5-derive | ||
run: cargo test --workspace -vvv --features hdf5-sys/static,hdf5-sys/zlib --exclude hdf5-derive | ||
- name: Build and test with filters and other features | ||
run: cargo test --workspace -v --features hdf5-sys/static,hdf5-sys/zlib,lzf,blosc,f16,complex --exclude hdf5-derive | ||
if: matrix.rust != 'stable-gnu' | ||
|
@@ -240,31 +239,31 @@ jobs: | |
- name: Build and test all crates | ||
run: cargo test -vv | ||
|
||
mingw: | ||
name: mingw | ||
runs-on: windows-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
rust: [stable] | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v3 | ||
with: {submodules: true} | ||
- name: Install Rust (${{matrix.rust}}) | ||
uses: dtolnay/rust-toolchain@stable | ||
with: {toolchain: '${{matrix.rust}}', targets: x86_64-pc-windows-gnu} | ||
- name: Install HDF5 | ||
shell: pwsh | ||
run: | | ||
$env:PATH="$env:PATH;C:\msys64\mingw64\bin;C:\msys64\usr\bin;" | ||
C:\msys64\usr\bin\pacman.exe -Syu --noconfirm | ||
C:\msys64\usr\bin\pacman.exe -S --noconfirm mingw-w64-x86_64-hdf5 mingw-w64-x86_64-pkgconf | ||
- name: Build and test all crates | ||
shell: pwsh | ||
run: | | ||
$env:PATH="$env:PATH;C:\msys64\mingw64\bin;" | ||
cargo test -vv --target=x86_64-pc-windows-gnu | ||
# mingw: | ||
# name: mingw | ||
# runs-on: windows-latest | ||
# strategy: | ||
# fail-fast: false | ||
# matrix: | ||
# rust: [stable] | ||
# steps: | ||
# - name: Checkout repository | ||
# uses: actions/checkout@v3 | ||
# with: {submodules: true} | ||
# - name: Install Rust (${{matrix.rust}}) | ||
# uses: dtolnay/rust-toolchain@stable | ||
# with: {toolchain: '${{matrix.rust}}', targets: x86_64-pc-windows-gnu} | ||
# - name: Install HDF5 | ||
# shell: pwsh | ||
# run: | | ||
# $env:PATH="$env:PATH;C:\msys64\mingw64\bin;C:\msys64\usr\bin;" | ||
# C:\msys64\usr\bin\pacman.exe -Syu --noconfirm | ||
# C:\msys64\usr\bin\pacman.exe -S --noconfirm mingw-w64-x86_64-hdf5 mingw-w64-x86_64-pkgconf | ||
# - name: Build and test all crates | ||
# shell: pwsh | ||
# run: | | ||
# $env:PATH="$env:PATH;C:\msys64\mingw64\bin;" | ||
# cargo test -vv --target=x86_64-pc-windows-gnu | ||
|
||
msrv: | ||
name: Minimal Supported Rust Version | ||
|
@@ -282,22 +281,22 @@ jobs: | |
run: | ||
cargo test --workspace -vv --features=hdf5-sys/static,hdf5-sys/zlib --exclude=hdf5-derive | ||
|
||
wine: | ||
name: wine | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v3 | ||
with: {submodules: true} | ||
- name: Install Rust | ||
uses: dtolnay/rust-toolchain@stable | ||
with: {toolchain: stable, targets: x86_64-pc-windows-gnu} | ||
- name: Install dependencies | ||
run: sudo apt-get update && sudo apt install wine64 mingw-w64 | ||
- name: Build and test | ||
env: | ||
CARGO_TARGET_X86_64_PC_WINDOWS_GNU_RUNNER: wine64 | ||
run: cargo test --workspace --features hdf5-sys/static --target x86_64-pc-windows-gnu --exclude=hdf5-derive | ||
# wine: | ||
# name: wine | ||
# runs-on: ubuntu-latest | ||
# steps: | ||
# - name: Checkout repository | ||
# uses: actions/checkout@v3 | ||
# with: {submodules: true} | ||
# - name: Install Rust | ||
# uses: dtolnay/rust-toolchain@stable | ||
# with: {toolchain: stable, targets: x86_64-pc-windows-gnu} | ||
# - name: Install dependencies | ||
# run: sudo apt-get update && sudo apt install wine64 mingw-w64 | ||
# - name: Build and test | ||
# env: | ||
# CARGO_TARGET_X86_64_PC_WINDOWS_GNU_RUNNER: wine64 | ||
# run: cargo test --workspace --features hdf5-sys/static --target x86_64-pc-windows-gnu --exclude=hdf5-derive | ||
|
||
addr_san: | ||
name: Address sanitizer | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule hdf5
updated
4553 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
.
intended to be escaped\.
? If not, the regex can be shortened. In any case, I now see version strings"1.14.4-2"
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably simplify it greatly by ignoring everything after
number.number.number