Avoid prematurely freeing buffer during value editing on Linux. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression in d58cd76, where the deletion of the `bufferCopy` buffer was moved to an earlier point. It was overlooked that the buffer is referenced by the `local` structure that used in the `process_vm_writev()` call.
dreamsyntax
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression in d58cd76, where the deletion of the
bufferCopybuffer was moved to an earlier point. It was overlooked that the buffer is referenced by thelocalstructure that used in theprocess_vm_writev()call.The symptoms were garbage being written into Dolphin's memory when the user would edit a value in a watch node (e.g. user enters
7in a integer, but251was written).Bonus: Some wrong assertions (a regression too, in e9c0e22) have been removed.