Remove remnants of the deactivated sorting mechanism. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sorting mechanism was deactivated in 65bb529, but the actual functionality was still in the code base. Note that sorting was disabled due to its implementation being destructive: the actual watch nodes were reordered; not just the visual representation of the items in the Qt tree view. If the functionality is reinstated in the future, a `QSortFilterProxyModel` should be used.
dreamsyntax
approved these changes
May 18, 2024
|
We probably wont ever want this feature, but a search filter that doesnt destroy the dmw struct could be cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sorting mechanism was deactivated in 65bb529, but the actual functionality was still in the code base.
Note that sorting was disabled due to its implementation being destructive: the actual watch nodes were reordered; not just the visual representation of the items in the Qt tree view. If the functionality is reinstated in the future, a
QSortFilterProxyModelshould be used.